[libvirt] [PATCH 12/n] conf: let snapshots share disk source struct

[Eric Blake]

On 03/31/2014 09:56 AM, Eric Blake wrote:
> On 03/31/2014 02:56 AM, Peter Krempa wrote:
>> On 03/29/14 23:20, Eric Blake wrote:
>>> Now that we have a common struct, it's time to start using it!
>>> Since external snapshots make a longer backing chain, it is
>>> only natural to use the same struct for the file created by
>>> the snapshot as what we use for <domain> disks.
>>>
> 

>> And here we can introduce a function to copy the source instead of doing
>> it manually.
> 
> Also a future patch that I was already planning on :)
> 
>>
>> ACK to the patch. The proposed changes are definitely separable and
>> better to review separately.
> 
> Good - we're on the same page.  Again, I'm waiting for this series until
> after 1.2.3 is out, but glad that it is ACKed so far.

I've pushed through here; the rest of what I've posted in this thread
(13-16) is something I'm still thinking about, and may rebase slightly
differently.  I'll start a new thread for my next work, which is trying
to merge virStorageFileMetadata and virStorageSource into a single struct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140401/1d604337/attachment-0001.sig>