[libvirt] [PATCHv2 1/7] conf: manage disk source by struct instead of pieces

[Peter Krempa]

On 04/02/14 05:04, Eric Blake wrote:
> Now that we have a dedicated type for representing a disk source,
> we might as well parse and format directly into that type instead
> of piecemeal into pointers to members of the type.
> 
> * src/conf/domain_conf.h (virDomainDiskSourceDefFormatInternal)
> (virDomainDiskSourceDefParse): Rename...
> (virDomainDiskSourceFormat, virDomainDiskSourceParse): ...and
> compress signatures.
> * src/conf/domain_conf.c (virDomainDiskSourceParse)
> (virDomainDiskSourceFormat): Rewrite to use common struct.
> (virDomainDiskSourceDefFormat): Delete.
> (virDomainDiskDefParseXML, virDomainDiskDefFormat): Update
> callers.
> * src/conf/snapshot_conf.c (virDomainSnapshotDiskDefParseXML)
> (virDomainSnapshotDiskDefFormat): Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/conf/domain_conf.c   | 139 ++++++++++++++++++-----------------------------
>  src/conf/domain_conf.h   |  24 ++------
>  src/conf/snapshot_conf.c |  17 +-----
>  3 files changed, 62 insertions(+), 118 deletions(-)
> 

ACK, this fixes my suggestion in one of the previous patches

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140402/d2684849/attachment-0001.sig>