[libvirt] [PATCHv2 6/7] conf: drop redundant parameters during probe

[Peter Krempa]

On 04/02/14 05:05, Eric Blake wrote:
> Now that each virStorageSource can track allocation information,
> and given that we already have the information without extra
> syscalls, it's easier to just always populate the information
> directly into the struct than it is to sometimes pass the address
> of the struct members down the call chain.
> 
> * src/storage/storage_backend.h (virStorageBackendUpdateVolInfo)
> (virStorageBackendUpdateVolTargetInfo)
> (virStorageBackendUpdateVolTargetInfoFD): Update signature.
> * src/storage/storage_backend.c (virStorageBackendUpdateVolInfo)
> (virStorageBackendUpdateVolTargetInfo)
> (virStorageBackendUpdateVolTargetInfoFD): Always populate struct
> members instead.
> * src/storage/storage_backend_disk.c
> (virStorageBackendDiskMakeDataVol): Update client.
> * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget)
> (virStorageBackendFileSystemRefresh)
> (virStorageBackendFileSystemVolRefresh): Likewise.
> * src/storage/storage_backend_gluster.c
> (virStorageBackendGlusterRefreshVol): Likewise.
> * src/storage/storage_backend_logical.c
> (virStorageBackendLogicalMakeVol): Likewise.
> * src/storage/storage_backend_mpath.c
> (virStorageBackendMpathNewVol): Likewise.
> * src/storage/storage_backend_scsi.c
> (virStorageBackendSCSINewLun): Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/storage/storage_backend.c         | 74 +++++++++++++----------------------
>  src/storage/storage_backend.h         |  7 +---
>  src/storage/storage_backend_disk.c    |  2 +-
>  src/storage/storage_backend_fs.c      | 16 +++-----
>  src/storage/storage_backend_gluster.c |  4 +-
>  src/storage/storage_backend_logical.c |  2 +-
>  src/storage/storage_backend_mpath.c   |  2 +-
>  src/storage/storage_backend_scsi.c    |  2 +-
>  8 files changed, 39 insertions(+), 70 deletions(-)
> 

ACK.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140402/05ed259d/attachment-0001.sig>