[libvirt] [PATCH 2/3] bhyve: create capabilities submodule

[Roman Bogorodskiy]

  Michal Privoznik wrote:

> On 02.04.2014 10:30, Wojciech Macek wrote:
> > Adding one minor change to copyrights header...
> >
> >
> >
> > - Move all capabilities functions to separate file
> > - Add initCPU
> > ---
> >   src/Makefile.am                |   2 +
> >   src/bhyve/bhyve_capabilities.c | 105 ++++++++++++++++++++++++++++++
> > +++++++++++
> >   src/bhyve/bhyve_capabilities.h |  30 ++++++++++++
> >   src/bhyve/bhyve_driver.c       |  56 +++++++++++++---------
> >   4 files changed, 171 insertions(+), 22 deletions(-)
> >   create mode 100644 src/bhyve/bhyve_capabilities.c
> >   create mode 100644 src/bhyve/bhyve_capabilities.h
> 
> This is not the best way to send patch as reply. I see you've used git 
> send-email to send the previous patches. If you want to send a v2 just 
> to a specific one (say 2/3), you should use git send-email too; just 
> specify in-reply-to and adjust subject prefix: PATCHv2: ....
> Moreover, sending patches other way than git send-email is tricky as you 
> need to make sure the lines are not wrapped (yes, it happened in this 
> case too).

And for minor changes I think it's easier to just command so the person
who will be pushing that could just squash that in instead of
re-applying the series.

As for the copyright change, I think, technically, I should be on a list
for bhyve_capabilities.c as well because it still contains some of the
code I previously wrote :-)

> Can you resend the v2? It's okay to send v2 just to a single patch.

Agreed, and v2 would be useful for another reason: I wasn't able to
apply this patch, git am gives me:

fatal: sha1 information is lacking or useless (src/bhyve/bhyve_driver.c).

I'd guess it reference some non-published or changed commit?

Thanks,

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140405/bb6beb9c/attachment-0001.sig>