[libvirt] [PATCH] libvirt-guests: avoid bashism
Guido Günther
agx at sigxcpu.org
Mon Apr 7 10:52:48 UTC 2014
On Mon, Apr 07, 2014 at 11:25:07AM +0200, Peter Krempa wrote:
> On 04/07/14 11:20, Guido Günther wrote:
> > At least Debian uses dash to run the init scripts
> > ---
> > tools/libvirt-guests.sh.in | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in
> > index 4bbd4e4..a158b62 100644
> > --- a/tools/libvirt-guests.sh.in
> > +++ b/tools/libvirt-guests.sh.in
> > @@ -89,13 +89,15 @@ test_connect()
> > {
> > uri=$1
> >
> > - for ((i = 0; i < ${CONNECT_RETRIES}; i++)); do
> > + i=${CONNECT_RETRIES}
> > + while [ $i -gt 0 ]; do
> > run_virsh "$uri" connect 2>/dev/null
> > if [ $? -eq 0 ]; then
> > return 0;
> > fi
> > sleep ${RETRIES_SLEEP}
> > eval_gettext "Unable to connect to libvirt currently. Retrying .. \$i"
> > + i=$(($i-1))
> > done
> > eval_gettext "Can't connect to \$uri. Skipping."
> > echo
> >
>
> ACK,
Pushed. Thanks,
-- Guido
More information about the libvir-list
mailing list