[libvirt] [PATCH] -Added autocloseable to connect class (set close() return type to void so to adapt it to the autocloseable interface)

Claudio Bley cbley at av-test.de
Tue Apr 8 14:19:20 UTC 2014


[forwarding my answer back to the list]

Pasquale, please keep the discussion on the list, you should probably
use the "Reply To All" (or whatever GMail calls it) button when
answering.

At Tue, 08 Apr 2014 16:09:31 +0200,
Claudio Bley wrote:
> 
> [Remember /not/ to top-post on technical lists.]
> 
> At Mon, 7 Apr 2014 20:28:28 +0200,
> Pasquale Dir wrote:
> > 
> > Hello,
> > is it ok if I'll send multiple patches for each added function? I'd start
> > with the getCPUStats which is the most complex as it introduces new jna
> > types too.
> 
> Yes, that would be a good start. (although I'd probably do it in
> reverse, starting out with the small changes, then tackling the
> complex ones).
> 
> > As for Thread.sleep() is it ok to substitute it with a wait(long) ? Or you
> > have any alternative? That wait is needed for the alghoritm to work.
> 
> I'm not convinced that this functionality belongs into the library at
> all.  Maybe we could add a convenience method doing the computation
> for two given stats and a time period, but I don't feel strongly in
> support of adding this method.
> 
> Regards,
> Claudio




More information about the libvir-list mailing list