[libvirt] [PATCH 2/3] storage: Refactor storage file initialization to use virStorageSourcePtr

Eric Blake eblake at redhat.com
Wed Apr 9 01:22:24 UTC 2014


On 04/08/2014 08:12 AM, Peter Krempa wrote:
> Now that storage source metadata is stored in a single struct we don't
> need two initialization functions for different structs.
> ---
>  src/qemu/qemu_driver.c        |  6 +++---
>  src/storage/storage_backend.c |  1 +
>  src/storage/storage_driver.c  | 41 +++++++----------------------------------
>  src/storage/storage_driver.h  |  8 +++-----
>  4 files changed, 14 insertions(+), 42 deletions(-)
> 

> +++ b/src/storage/storage_driver.h
> @@ -25,8 +25,8 @@
>  # define __VIR_STORAGE_DRIVER_H__
> 
>  # include "storage_conf.h"
> -# include "conf/domain_conf.h"
> -# include "conf/snapshot_conf.h"
> +# include "virstoragefile.h"
> +# include <sys/stat.h>

We tend to list <system> includes prior to "local" includes.

ACK with that reordered.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140408/b1a5c10c/attachment-0001.sig>


More information about the libvir-list mailing list