[libvirt] [PATCH 1/6] conf: track user vs. canonical name through full chain lookup

[Peter Krempa]

On 04/09/14 06:35, Eric Blake wrote:
> The previous patch started a separation of error messages
> reported against the user-specified name, vs. tracking the
> canonical path that was actually opened.  This patch extends
> that notion, by hoisting directory detection up front, passing
> the canonical path through the entire call chain, and
> simplifying lower-level functions that can now assume that
> a canonical path and directory have been supplied.
> 
> * src/util/virstoragefile.c
> (virStorageFileGetMetadataFromFDInternal)
> (virStorageFileGetMetadataInternal): Add parameter, require
> directory.
> (virFindBackingFile): Require directory.
> (virStorageFileGetMetadataFromFD): Pass canonical path.
> (virStorageFileGetMetadataFromBuf): Likewise.
> (virStorageFileGetMetadata): Determine initial directory.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/util/virstoragefile.c | 97 ++++++++++++++++++++++++++++-------------------
>  1 file changed, 59 insertions(+), 38 deletions(-)
> 


ACK,

Peter



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140409/8f449708/attachment-0001.sig>