[libvirt] [PATCH 2/6] conf: earlier allocation during backing chain crawl

[Peter Krempa]

On 04/09/14 06:35, Eric Blake wrote:
> Right now, we are allocating virStorageFileMetadata near the bottom
> of the callchain, only after we have identified that we are visiting
> a file (and not a network resource).  I'm hoping to eventually
> support parsing the backing chain from XML, where the backing chain
> crawl then validates what was parsed rather than allocating a fresh
> structure.  Likewise, I'm working towards a setup where we have a
> backing element even for networks.  Both of these use cases are
> easier to code if the allocation is hoisted earlier.
> 
> * src/util/virstoragefile.c (virStorageFileGetMetadataInternal)
> (virStorageFileGetMetadataFromFDInternal): Change signature.
> (virStorageFileGetMetadataFromBuf)
> (virStorageFileGetMetadataRecurse, virStorageFileGetMetadata):
> Update callers.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/util/virstoragefile.c | 126 +++++++++++++++++++++++++++-------------------
>  1 file changed, 75 insertions(+), 51 deletions(-)
> 


ACK,

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140409/54f0e768/attachment-0001.sig>