[libvirt] [PATCH 5/6] conf: start testing contents of the new backing chain fields

[Eric Blake]

On 04/09/2014 06:11 AM, Peter Krempa wrote:
> On 04/09/14 06:35, Eric Blake wrote:
>> The testsuite is absolutely essential to feeling comfortable
>> about swapping the backing chain structure over to a new format.
>> This patch tests the path settings, and demonstrates that the
>> correct short name is being passed to the child.
>>
>> * tests/virstoragetest.c (testStorageChain): Test path.
>> (mymain): Update expected data.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  tests/virstoragetest.c | 69 ++++++++++++++++++++++++++++++++++++++++----------
>>  1 file changed, 56 insertions(+), 13 deletions(-)
>>
>> diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
>> index 093053a..9c2f815 100644
>> --- a/tests/virstoragetest.c
>> +++ b/tests/virstoragetest.c
> 
>> @@ -294,22 +297,28 @@ testStorageChain(const void *args)
>>
>>          expBackingDirectory = abs ? data->files[i]->expBackingDirAbs
>>              : data->files[i]->expBackingDirRel;
>> +        expPath = abs ? data->files[i]->pathAbs
>> +            : data->files[i]->pathRel;
> 
> This will need to be updated as in 2/6 due of the upstream changes.

Yep, I figured that out pretty quickly.

> 
> ACK with build failure resolved.

Thanks; series pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140409/270bfa43/attachment-0001.sig>