[libvirt] [PATCH 4/5] conf: return backing information separately from metadata

Peter Krempa pkrempa at redhat.com
Thu Apr 10 10:30:26 UTC 2014


On 04/10/14 05:41, Eric Blake wrote:
> A couple pieces of virStorageFileMetadata are used only while
> collecting information about the chain, and don't need to
> live permanently in the struct.  This patch refactors external
> callers to collect the information separately, so that the
> next patch can remove the fields.
> 
> * src/util/virstoragefile.h (virStorageFileGetMetadataFromBuf):
> Alter signature.
> * src/util/virstoragefile.c (virStorageFileGetMetadataInternal):
> Likewise.
> (virStorageFileGetMetadataFromFDInternal): Adjust callers.
> * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget):
> Likewise.
> * src/storage/storage_backend_gluster.c
> (virStorageBackendGlusterRefreshVol): Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/storage/storage_backend_fs.c      | 34 ++++++++++++++-----------------
>  src/storage/storage_backend_gluster.c | 14 ++++++-------
>  src/util/virstoragefile.c             | 38 ++++++++++++++++++++---------------
>  src/util/virstoragefile.h             |  6 +++++-
>  4 files changed, 48 insertions(+), 44 deletions(-)
> 

ACK,

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140410/9e8df8be/attachment-0001.sig>


More information about the libvir-list mailing list