[libvirt] [PATCH 03/26] Remove pointless storage of var names in virNWFilterHashTable

Eric Blake eblake at redhat.com
Mon Apr 14 21:24:34 UTC 2014


On 04/08/2014 09:37 AM, Daniel P. Berrange wrote:
> The virNWFilterHashTable struct contains a virHashTable and
> then a 'char **names' field which keeps a copy of all the
> hash keys. Presumably this was intended to record the ordering
> of the hash keys. No code ever uses this and the ordering is
> mangled whenever a variable is removed from the hash, because
> the last element in the list is copied into the middle of the
> list when shrinking the arra.

s/arra/array/

> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140414/b9be1dd8/attachment-0001.sig>


More information about the libvir-list mailing list