[libvirt] [PATCH tck] 202-numa-set-parameters.t: use AFFECT_CONFIG when changing nodeset

Daniel P. Berrange berrange at redhat.com
Tue Apr 15 09:29:00 UTC 2014


On Wed, Apr 09, 2014 at 03:12:47PM -0600, Mike Latimer wrote:
> The 202-numa-set-parameters.t test sets NUMA_NODESET using AFFECT_LIVE on a
> running domain, destroys and starts the domain, then verifies the NUMA_NODESET
> setting. As AFFECT_LIVE does not write the setting to the domain xml file,
> the new nodeset setting is lost when the domain is destroyed and the test
> fails.
> 
> This patch adds AFFECT_CONFIG to set_numa_parameters, so both the live
> environment and the xml file are updated with the new setting. An additional
> test was also added, before the domain is destroyed, to ensure the nodeset
> change is seen on the live domain.
> 
> ---
>  scripts/domain/202-numa-set-parameters.t | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list