[libvirt] [PATCH 13/26] Replace virNetworkObjPtr with virNetworkDefPtr in network platform APIs

Stefan Berger stefanb at linux.vnet.ibm.com
Tue Apr 15 22:00:15 UTC 2014


On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
> The networkCheckRouteCollision, networkAddFirewallRules and
> networkRemoveFirewallRules APIs all take a virNetworkObjPtr
> instance, but only ever access the 'def' member. It thus
> simplifies testing if the APIs are changed to just take a
> virNetworkDefPtr instead
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>


> diff --git a/src/network/bridge_driver_platform.h b/src/network/bridge_driver_platform.h
> index 6a571da..a1286da 100644
> --- a/src/network/bridge_driver_platform.h
> +++ b/src/network/bridge_driver_platform.h
> @@ -21,6 +21,7 @@
>    * Author: Daniel P. Berrange <berrange at redhat.com>
>    */
>
> +

This may be the only unnecessary part.

Otherwise a replacement by pattern. Compile doesn't complain ... ACK




More information about the libvir-list mailing list