[libvirt] [PATCHv2 0/9] RelaxNG improvements for virStorageSource
Jiri Denemark
jdenemar at redhat.com
Wed Apr 16 09:03:50 UTC 2014
On Mon, Apr 14, 2014 at 16:54:11 -0600, Eric Blake wrote:
> changes since v1:
> ack'd patch pushed
> new patches 2-4 are a better rewrite of old patch 3/6
> new patches 8 and 9
> patch 9 is incomplete - I know where I want to be headed, but
> changing 400+ tests is taking a while. I tried:
>
> $ git grep -l '<driver.*type=' tests/*data/ | \
> xargs sed '
> /<driver .*type=\(\(.\)[a-zA-Z0-9]*\2\)/ h;
> /<source /{
> x;
> s/<driver.*type=\(\(.\)[a-zA-Z0-9]*\2\).*>/<format type=\1>/;
> G;
> }'
>
> as a way to automate the majority of the tedium, with some limited
> success (it has false positives in the lxc <filesystem> elements,
> when we really only want to affect <disk> elements>), but have not
> completed the efforts. I'm posting the patches now, in the hopes
> that 1-8 can be approved, and 9 picked up by someone else if I'm
> unresponsive for a while (I'll be offline for much of this week due
> to the birth of my fourth child).
>
> Eric Blake (9):
> conf: better <disk> interleaving in schema
> conf: move storage formats to common RNG file
> conf: restrict external snapshots to backing store formats
> conf: set up for per-grammar overrides in schemas
> conf: split <disk> schema into more pieces
> conf: move storage source details to common RNG file
> conf: move <auth> and <encryption> to disk source
> conf: fix omission of <driver> in domain dumpxml
> RFC: conf: introduce <format> as synonym of <driver type=...>
I pushed the patches I ACKed (1, 2, 3, 4, 5, and 8) with the suggested
additions. I think the rest can be left for the future if needed.
Jirka
More information about the libvir-list
mailing list