[libvirt] [PATCH 18/26] Convert nwfilter ebtablesRemoveBasicRules to virFirewall

[Daniel P. Berrange]

On Wed, Apr 16, 2014 at 09:45:56AM -0400, Stefan Berger wrote:
> On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
> >Convert the nwfilter ebtablesRemoveBasicRules method to use the
> >virFirewall object APIs instead of creating shell scripts
> >using virBuffer APIs. This provides a performance improvement
> >through allowing direct use of firewalld dbus APIs and will
> >facilitate automated testing.
> >
> >Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> >
> 
> >
> >  static void
> >-ebtablesRemoveSubChainsFW(virFirewallPtr fw,
> >-                          const char *ifname)
> >+ebtablesRemoveTmpSubChains(virBufferPtr buf,
> >+                           const char *ifname)
> >  {
> >      char chains[3] = {
> >-        CHAINPREFIX_HOST_IN,
> >-        CHAINPREFIX_HOST_OUT,
> >+        CHAINPREFIX_HOST_IN_TEMP,
> >+        CHAINPREFIX_HOST_OUT_TEMP,
> >          0
> >      };
> >
> >-    _ebtablesRemoveSubChainsFW(fw, ifname, chains);
> >+    _ebtablesRemoveSubChains(buf, ifname, chains);
> >  }
> 
> This is really the only odd part about this patch, a conversion in
> the other direction. Maybe not-yet converted code needs it at this
> point.

This is just 'diff' producing a very misleading patch context - we're
not actually reverting the previous change.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|