[libvirt] [PATCH] storageVolCreateXMLFrom: Allow multiple accesses to origvol

[Daniel P. Berrange]

On Wed, Apr 16, 2014 at 04:05:38PM +0200, Michal Privoznik wrote:
> When creating a new volume, it is possible to copy data into it from
> another already existing volume (referred to as @origvol). Obviously,
> the read-only access to @origvol is required, which is thread safe
> (probably not performance-wise though). However, with current code
> both @newvol and @origvol are marked as building for the time of
> copying data from the @origvol to @newvol. The rationale behind
> is to disallow some operations on both @origvol and @newvol, e.g.
> vol-wipe, vol-delete, vol-download. While it makes sense to not allow
> such operations on partly copied mirror, but it doesn't make sense to
> disallow the operations on the source (@origvol).

What if someone tries to delete or resize or otherwise change the
source volume while the copy is still in progress ? We could just
say that's user error I guess.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|