[libvirt] qemu: Unlock the NWFilter update lock by leaving via the cleanup label

Ján Tomko jtomko at redhat.com
Thu Apr 17 06:31:18 UTC 2014


On 04/16/2014 11:54 PM, Stefan Berger wrote:
> Fix a locking problem by leaving the function via the cleanup label.
> 
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> 
> ---
>  src/qemu/qemu_driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK

> Index: libvirt-acl/src/qemu/qemu_driver.c
> ===================================================================
> --- libvirt-acl.orig/src/qemu/qemu_driver.c
> +++ libvirt-acl/src/qemu/qemu_driver.c
> @@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr d
>      virNWFilterReadLockFilterUpdates();
> 
>      if (!(vm = qemuDomObjFromDomain(dom)))
> -        return -1;
> +        goto cleanup;
> 
>      if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0)
>          goto cleanup;
> 
> -- 
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140417/ec41c6b4/attachment-0001.sig>


More information about the libvir-list mailing list