[libvirt] [PATCHv2 0/4] network: fix active status & usage of inactive networks

Laine Stump laine at laine.org
Thu Apr 17 11:43:18 UTC 2014


The original patch series is here:

  https://www.redhat.com/archives/libvir-list/2014-April/msg00454.html

This repost addresses problems pointed out by John Ferlan in his
review (and other things that I thought better of during the
revisions).

All 4 patches are required to address

  https://bugzilla.redhat.com/show_bug.cgi?id=880483

The reported problem is that an interface using a currently-inactive
macvtap/hostdev network can be attached to a domain (addressed by
4/4). In order to make fixing that problem less, well, problematic,
the automatic inactivation of all macvtap/hostdev networks any time
libvirtd is restart must be addressed, and that is done in 1/4-3/4.

Part of fixing the latter problem is changing the network driver to
use /var/run for its status XML rather than /var/lib (2/4), which
could cause problems during upgrade (also addressed in 2/4) and in a
more limited sense downgrade (see the comments in 2/4 for why I
decided to not address those problems).

Laine Stump (4):
  network: create statedir during driver initialization
  network: change location of network state xml files
  network: set macvtap/hostdev networks active if their state file
    exists
  network: centralize check for active network during interface attach

 src/conf/network_conf.c     |   1 +
 src/lxc/lxc_driver.c        |  21 +----
 src/lxc/lxc_process.c       |  18 +----
 src/network/bridge_driver.c | 189 ++++++++++++++++++++++++++++++++++++--------
 src/qemu/qemu_command.c     |  18 +----
 src/qemu/qemu_hotplug.c     |  11 +--
 6 files changed, 166 insertions(+), 92 deletions(-)

-- 
1.9.0




More information about the libvir-list mailing list