[libvirt] [PATCH] Fix typos in src/*

Eric Blake eblake at redhat.com
Mon Apr 21 22:49:01 UTC 2014


On 04/20/2014 02:07 PM, Nehal J Wani wrote:
> Fix minor typos in source comments
> 
> ---

Thanks for doing this!  Any particular tool you used for finding these?

	> +++ b/src/esx/esx_storage_backend_iscsi.c
> @@ -460,7 +460,7 @@ esxStorageVolLookupByName(virStoragePoolPtr pool,
>           scsiLun = scsiLun->_next) {
>          if (STREQ(scsiLun->deviceName, name)) {
>              /*
> -             * ScsiLun provides an UUID field that is unique accross
> +             * ScsiLun provides an UUID field that is unique across

While at it, s/an UUID/a UUID/.  I added that fix to your patch across 6
locations in the source.


> +++ b/src/interface/interface_backend_netcf.c
> @@ -151,7 +151,7 @@ netcfStateReload(void)
>  /*
>   * Get a minimal virInterfaceDef containing enough metadata
>   * for access control checks to be performed. Currently
> - * this implies existance of name and mac address attributes
> + * this implies existence of name and mac address attributes

While at it, I found several more instances of 'existan...' that I
changed to 'existen...'

> +++ b/src/openvz/openvz_conf.c
> @@ -215,7 +215,7 @@ openvzReadNetworkConf(virDomainDefPtr def,
>      /*parse routing network configuration*
>       * Sample from config:
>       *   IP_ADDRESS="1.1.1.1 1.1.1.2"
> -     *   splited IPs by space
> +     *   splitted IPs by space

splitted is not a word.  I changed this to 'split'.

> +++ b/src/qemu/qemu_command.h
> @@ -39,7 +39,7 @@
>  # define QEMU_FSDEV_HOST_PREFIX "fsdev-"
>  
>  /* These are only defaults, they can be changed now in qemu.conf and
> - * explicitely specified port is checked against these two (makes
> + * explicitly specified port is checked against these two (makes

I fixed another instance of Explicitely in news.html.in.

> +++ b/src/security/security_selinux.c
> @@ -178,7 +178,7 @@ virSecuritySELinuxMCSFind(virSecurityManagerPtr mgr,
>   * the category part, since that's what we're really
>   * interested in. This won't work in Enforcing mode,
>   * but will prevent libvirtd breaking in Permissive
> - * mode when run with a wierd process label.
> + * mode when run with a weird process label.

I fixed another instance of wierd in news.html.in.

> +++ b/src/util/virstring.c
> @@ -758,7 +758,7 @@ virStringSearch(const char *str,
>   * @oldneedle: the substring to locate
>   * @newneedle: the substring to insert
>   *
> - * Search @haystack and replace all occurences of @oldneedle with @newneedle.
> + * Search @haystack and replace all occurrences of @oldneedle with @newneedle.

virfile.c had a similar typo with 'occured'

>   *
>   * Returns the path to the serial console. It is the callers
> - * responsibilty to free() the return string. Returns NULL
> + * responsibility to free() the return string. Returns NULL

Searching for 'bilty' found another typo 'reliabilty' in news.html.in

ACK and pushed with additional typo fixes squashed in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140421/cf2f3ad4/attachment-0001.sig>


More information about the libvir-list mailing list