[libvirt] [PATCH 16/18] storage: Move disk->backingChain to the recursive disk->src.backingStore

[Eric Blake]

On 04/20/2014 04:13 PM, Peter Krempa wrote:
> Switch over to storing of the backing chain as a recursive
> virStorageSource structure.
> 
> This is a string based move. Currently the first element will be present
> twice in the backing chain as currently the retrieval function stores
> the parent in the newly detected chain. This will be fixed later.
> ---
>  src/conf/domain_conf.c          |  5 ++---
>  src/conf/domain_conf.h          |  1 -
>  src/qemu/qemu_domain.c          | 20 ++++++++++----------
>  src/qemu/qemu_driver.c          | 30 +++++++++++++++---------------
>  src/security/security_selinux.c |  2 +-
>  src/security/virt-aa-helper.c   |  8 ++++----
>  6 files changed, 32 insertions(+), 34 deletions(-)
> 

> @@ -12730,13 +12730,13 @@ qemuDomainSnapshotCreateSingleDiskActive(virQEMUDriverPtr driver,
>      if (virAsprintf(&device, "drive-%s", disk->info.alias) < 0)
>          goto cleanup;
> 
> -    /* XXX Here, we know we are about to alter disk->backingChain if
> +    /* XXX Here, we know we are about to alter disk->src.backingStore if
>       * successful, so we nuke the existing chain so that future commands will
>       * recompute it.  Better would be storing the chain ourselves rather than
>       * reprobing, but this requires modifying domain_conf and our XML to fully
>       * track the chain across libvirtd restarts.  */

Nice to know we are getting closer to fixing this comment.

Indeed mechanical, and I agree with your choice for the awkward
double-storage of the top of the chain until a later patch.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140422/96e32586/attachment-0001.sig>