[libvirt] [PATCHv2 4/6] Use virGetUninstalledDir() in src/storage/storage_backend_disk.c

Eric Blake eblake at redhat.com
Thu Apr 24 14:38:41 UTC 2014


On 04/24/2014 07:51 AM, Daniel P. Berrange wrote:
> On Tue, Mar 25, 2014 at 01:53:14PM +0530, Nehal J Wani wrote:
>> src/storage/storage_backend_disk.c:
>>    *Check if libvirtd is running uninstalled from a build tree and change
>>     parthelper_path accordingly
>>

> Hmm, it getting rather ugly & tedious to repeat this logic every
> place we need it.

I came to the same conclusion yesterday :)

> 
> I think we need another helper API really
> 
>    virFileFindBinary(const char *srcdir,
>                      const char *bindir,
>                      const char *binaryname);

Slightly different signature than my proposal - please read
https://www.redhat.com/archives/libvir-list/2014-April/msg00902.html
before doing too much duplicate work.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140424/4dad4726/attachment-0001.sig>


More information about the libvir-list mailing list