[libvirt] [PATCHv2 0/7] saner readdir usage

Eric Blake eblake at redhat.com
Mon Apr 28 23:54:38 UTC 2014


On 04/28/2014 03:23 AM, Ján Tomko wrote:
> On 04/26/2014 06:14 AM, Eric Blake wrote:
>> This extends the work started by Nataneal to cover the entire
>> tree.  Basically, readdir() is awkward to use correctly: to
>> properly check for (unlikely) errors, one must pre-set errno.
>> Forcing everything to go through a wrapper ensures that all
>> our uses will be consistent; this also fixes several bugs
>> in some of the call sites.
>>
>> Eric Blake (5):
>>   conf: use virDirRead API
>>   util: use virDirRead API
>>   drivers: use virDirRead API
>>   storage: use virDirRead API
>>   enforce sane readdir usage
>>
>> Natanael Copa (2):
>>   util: introduce virDirRead wrapper for readdir
>>   nodeinfo: use virDirRead API
>>

> 
> ACK series if you conver the newly addded readdir call as well:
> src/network/bridge_driver.c:487:        entry = readdir(dir);
> maint.mk: use virDirRead, not readdir
> make: *** [sc_prohibit_readdir] Error 1

I've pushed the series, including Laine's addition.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140428/ef2a8a4c/attachment-0001.sig>


More information about the libvir-list mailing list