[libvirt] [PATCH] storage_backend_rbd: Correct argument order to rbd_create3

[Eric Blake]

On 04/28/2014 08:19 PM, Steven McDonald wrote:
> The stripe_unit and stripe_count arguments are passed to rbd_create3 in
> the wrong order, resulting in a stripe size of 1 byte with 4194304
> stripes on newly created RBD volumes.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1092208
> Signed-off-by: Steven McDonald <steven.mcdonald at anchor.net.au>
> ---
>  src/storage/storage_backend_rbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
> index 029d2f0..5d4ef79 100644
> --- a/src/storage/storage_backend_rbd.c
> +++ b/src/storage/storage_backend_rbd.c
> @@ -492,7 +492,7 @@ static int virStorageBackendRBDCreateImage(rados_ioctx_t io,
>      uint64_t stripe_unit = 4194304;
>  
>      if (rbd_create3(io, name, capacity, features, &order,
> -                    stripe_count, stripe_unit) < 0) {
> +                    stripe_unit, stripe_count) < 0) {

Thanks.  ACK and pushed, and congrats on your first libvirt patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140428/17268219/attachment-0001.sig>