[libvirt] [PATCH] bhyve: implement domainGetCPUStats

[Roman Bogorodskiy]

  Ján Tomko wrote:

> On 04/24/2014 11:14 AM, Roman Bogorodskiy wrote:
> >   Ján Tomko wrote:
> > 
> >> On 04/22/2014 07:44 PM, Roman Bogorodskiy wrote:
> >>> For per CPU stats, implement virBhyveGetDomainPercpuStats() that
> >>> uses bhyvectl tool to obtain the guest's vcpu stats.
> >>>
> >>
> >> In virDomainGetCPUStats API, the start_cpu and ncpus parameters refer to host
> >> CPUs, not the vcpus.
> > 
> > Looks like I misunderstood the API. :-(
> > 
> > In other words, this API operates with the host CPUs? So if user calls
> > it with e.g. start_cpu = 2 and ncpus = 2, I should return info on how
> > much time host CPUs 2 and 3 spend on the given domain (as the opposite
> > to how much time domain's vcpu 2 and vcpu 3 were busy)?
> > 
> 
> Yes.
> 
> Jan
> 

Looks like FreeBSD does not support such kind of per-cpu reporting for
host cpus. Just to make sure I didn't miss something, I asked that
question of the FreeBSD virtualization maillist and looks like I'm right
about that [1].

Would it better to abandon this feature for now and wait when it'd be
supported (I'm not sure if/when it's going to happen), or just leave the
code that reports only the stats for all cpus?

1: http://lists.freebsd.org/pipermail/freebsd-virtualization/2014-April/002477.html

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140429/c5af6f07/attachment-0001.sig>