[libvirt] [PATCH v2 1/2] bhyve: improve bhyve_command.c testability

[Daniel P. Berrange]

On Mon, Apr 14, 2014 at 08:25:14PM +0400, Roman Bogorodskiy wrote:
> * bhyve_command.c (bhyveBuildNetArgStr, virBhyveProcessBuildBhyveCmd):
>   add dryRun mode which doesn't create any devices when enabled
> * bhyve_command.c (virBhyveProcessBuildBhyveCmd,
>   virBhyveProcessBuildDestroyCmd, virBhyveProcessBuildLoadCmd): accept
>   virDomainDefPtr instead of virDomainObjPtr.
> ---
>  src/bhyve/bhyve_command.c | 85 +++++++++++++++++++++++++----------------------
>  src/bhyve/bhyve_command.h |  6 ++--
>  src/bhyve/bhyve_process.c | 10 +++---
>  tests/bhyvexml2argvtest.c |  2 +-
>  4 files changed, 56 insertions(+), 47 deletions(-)

ACK, 

though I'm afraid I don't think this counts a post-freeze
merge material

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|