[libvirt] [PATCH v6 4/6] qemu: Implement virDomainFSFreeze and virDomainFSThaw

[Daniel P. Berrange]

On Tue, Apr 29, 2014 at 08:04:18PM -0400, Tomoki Sekiyama wrote:
> Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are
> already implemented for snapshot quiescing.
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama at hds.com>
> ---
>  src/qemu/qemu_driver.c |   89 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 89 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index c3e0682..6bfd508 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -16528,6 +16528,93 @@ qemuConnectGetCPUModelNames(virConnectPtr conn,
>  }
>  
>  
> +static int
> +qemuDomainFSFreeze(virDomainPtr dom,
> +                   const char **mountpoints,
> +                   unsigned int nmountpoints,
> +                   unsigned int flags)
> +{
> +    virQEMUDriverPtr driver = dom->conn->privateData;
> +    virDomainObjPtr vm;
> +    int ret = -1;
> +
> +    virCheckFlags(0, -1);
> +
> +    if (mountpoints || nmountpoints)
> +        VIR_INFO("mountpoints option is not supported and ignored for now");

We should report VIR_ERR_ARGUMENT_UNSUPPORTED and return -1 to
the caller


> +static int
> +qemuDomainFSThaw(virDomainPtr dom,
> +                 const char **mountpoints ATTRIBUTE_UNUSED,
> +                 unsigned int nmountpoints ATTRIBUTE_UNUSED,
> +                 unsigned int flags)
> +{
> +    virQEMUDriverPtr driver = dom->conn->privateData;
> +    virDomainObjPtr vm;
> +    int ret = -1;
> +
> +    virCheckFlags(0, -1);

Same comment about VIR_ERR_ARGUMENT_UNSUPPORTED for nmountpoints
being non-NULL.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|