[libvirt] [PATCH v6 6/6] qemu: Support mountpoints option of guest-fsfreeze-freeze

[Daniel P. Berrange]

On Tue, Apr 29, 2014 at 08:04:31PM -0400, Tomoki Sekiyama wrote:
> With this patch, virDomainFSFreeze will pass the mountpoints argument
> to qemu guest agent. For example,
> 
>   virDomainFSFreeze(dom, {"/mnt/vol1", "/mnt/vol2"}, 2, 0)
> 
> will issue qemu guest agent command:
> 
>   {"execute":"guest-fsfreeze-freeze",
>    "arguments":{"mountpoints": ["/mnt/vol1","/mnt/vol2"]}}
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama at hds.com>
> ---
>  src/qemu/qemu_agent.c  |   47 +++++++++++++++++++++++++++++++++++++++++++----
>  src/qemu/qemu_agent.h  |    3 ++-
>  src/qemu/qemu_driver.c |   13 ++++++-------
>  tests/qemuagenttest.c  |    8 +++++---
>  4 files changed, 56 insertions(+), 15 deletions(-)

Hmm, seems QEMU guest agent silently ignores the mountpoints argument
in the Win32 impl which rather sucks. We should ask QEMU to give us a
way to query whether it is supported or not, so we can send a proper
error message back to the app

ACK, not a problem with your patch though.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|