[libvirt] [PATCH] nwfilter: Tear down temp. filters when tearing all filters

Stefan Berger stefanb at us.ibm.com
Wed Apr 30 15:44:57 UTC 2014


"Daniel P. Berrange" <berrange at redhat.com> wrote on 04/30/2014 10:59:59 
AM:

> From: "Daniel P. Berrange" <berrange at redhat.com>
> To: Stefan Berger/Watson/IBM at IBMUS, 
> Cc: libvirt-list at redhat.com, Stefan Berger <stefanb at linux.vnet.ibm.com>
> Date: 04/30/2014 11:05 AM
> Subject: Re: [PATCH] nwfilter: Tear down temp. filters when tearing 
> all filters
> 
> On Mon, Apr 28, 2014 at 07:02:22AM -0400, Stefan Berger wrote:
> > From: Stefan Berger <stefanb at linux.vnet.ibm.com>
> > 
> > Refactor the ebiptablesTearNewRules function so that the teardown 
> of temporary
> > filters can also be called by the ebiptablesAllTeardown function.
> > 
> > This fixes a problem that leaves temporary filters behind when a 
> VM shuts down
> > while its filters are modified.
> > 
> > Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> > ---
> >  src/nwfilter/nwfilter_ebiptables_driver.c | 24 
++++++++++++++++--------
> >  1 file changed, 16 insertions(+), 8 deletions(-)
> 
> ACK, ok for freeze.

Well, it now produces more commands to clear filters. I will have to adapt 
the test cases as well.

Regards,
   Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140430/53301478/attachment-0001.htm>


More information about the libvir-list mailing list