[libvirt] [PATCH] LXC: Fix virLXCControllerSetupDevPTS() wrt user namespaces

Richard Weinberger richard at nod.at
Tue Aug 5 19:55:25 UTC 2014


Am 29.07.2014 05:45, schrieb chenhanxiao at cn.fujitsu.com:
> 
> 
>> -----Original Message-----
>> From: libvir-list-bounces at redhat.com [mailto:libvir-list-bounces at redhat.com]
>> On Behalf Of Richard Weinberger
>> Sent: Tuesday, July 29, 2014 4:59 AM
>> To: libvir-list at redhat.com
>> Cc: Richard Weinberger; david at sigma-star.at
>> Subject: [libvirt] [PATCH] LXC: Fix virLXCControllerSetupDevPTS() wrt user
>> namespaces
>>
>> The gid value passed to devpts has to be translated by hand as
>> virLXCControllerSetupDevPTS() is called before setting up the user
>> and group mappings.
>> Otherwise devpts will use an unmapped gid and openpty()
>> will fail within containers.
>> Linux commit commit 23adbe12
>> ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid")
>> uncovered that issue.
>>
>> Signed-off-by: Richard Weinberger <richard at nod.at>
> 
> Reviewed-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 

ping

Thanks,
//richard




More information about the libvir-list mailing list