[libvirt] [PATCH] docs: use unique dev names in <disk> examples

[Martin Kletzander]

On Thu, Aug 07, 2014 at 08:38:11AM -0600, Eric Blake wrote:
>Jiri Moskovcak reported on IRC that the documentation on valid
><disk> was confusing because it didn't have unique dev='...'
>entries.
>
>* docs/formatdomain.html.in: Use unique names.
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>---
> docs/formatdomain.html.in |   26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
>
>diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>index 8950959..08f31c4 100644
>--- a/docs/formatdomain.html.in
>+++ b/docs/formatdomain.html.in
[...]
>@@ -1601,12 +1601,12 @@
>       <source dev='/dev/sda'/>
>       <geometry cyls='16383' heads='16' secs='63' trans='lba'/>
>       <blockio logical_block_size='512' physical_block_size='4096'/>
>-      <target dev='hda' bus='ide'/>
>+      <target dev='sdb' bus='ide'/>

This one should start with "hd", it's IDE.  Or the bus should be
changed.

>     </disk>
>     <disk type='volume' device='disk'>
>       <driver name='qemu' type='raw'/>
>       <source pool='blk-pool0' volume='blk-pool0-vol0'/>
>-      <target dev='hda' bus='ide'/>
>+      <target dev='sdc' bus='ide'/>

The same applies here.

>     </disk>
>     <disk type='network' device='disk'>
>       <driver name='qemu' type='raw'/>
>@@ -1626,7 +1626,7 @@
>       <auth username='myuser'>
>         <secret type='iscsi' usage='libvirtiscsi'/>
>       </auth>
>-      <target dev='sda' bus='scsi'/>
>+      <target dev='vdb' bus='scsi'/>

This one should start with "sd", it's SCSI.

Rest looks fine, ACK if you match the dev/bus in those three mentioned
places.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140807/6ce74f0a/attachment-0001.sig>