[libvirt] [PATCH 5/5] src/xenconfig: move common parsing/formatting to xen_common
Eric Blake
eblake at redhat.com
Mon Aug 18 16:10:49 UTC 2014
On 08/15/2014 09:50 PM, Jim Fehlig wrote:
> XM and XL config are very similar. Disks are specified differently
> in XL, but the old XM disk config is still supported by XL. XL also
> supports new config like spice that was never supported by XM.
>
> This patch moves all the common parsing and formatting functions to
> the new file xen_common.c and adapts the XM parser/formatter accordingly.
> This restructuring paves way for introducing an XL parser/formatter in
> the future.
>
> While moving the code, fixup whitespace, comments, and style issues.
>
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
> po/POTFILES.in | 1 +
> src/Makefile.am | 1 +
> src/xenconfig/xen_common.c | 2072 +++++++++++++++++++++++++++++++++++++++++
> src/xenconfig/xen_common.h | 46 +
> src/xenconfig/xen_xm.c | 2187 ++------------------------------------------
> src/xenconfig/xen_xm.h | 10 -
> 6 files changed, 2205 insertions(+), 2112 deletions(-)
Big, but seems mostly mechanical. I checked the diff via:
$ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^\+//p' patch)
to make sure that most of the differences were indeed whitespace. It
might have been a better idea to split into a couple of patches
(cleaning up style separately from renaming), but not worth the effort
to go back and redo it now.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140818/0151286d/attachment-0001.sig>
More information about the libvir-list
mailing list