[libvirt] [PATCH 4/5] src/xenconfig: remove dead code

Jim Fehlig jfehlig at suse.com
Tue Aug 19 03:17:34 UTC 2014


On 08/18/2014 10:03 AM, Eric Blake wrote:
> On 08/15/2014 09:50 PM, Jim Fehlig wrote:
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>> ---
>>   src/xenconfig/xen_xm.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c
>> index 0402213..83cc8c6 100644
>> --- a/src/xenconfig/xen_xm.c
>> +++ b/src/xenconfig/xen_xm.c
>> @@ -29,7 +29,6 @@
>>   #include "virerror.h"
>>   #include "virconf.h"
>>   #include "viralloc.h"
>> -#include "verify.h"
>>   #include "viruuid.h"
>>   #include "virsexpr.h"
>>   #include "count-one-bits.h"
>> @@ -2414,10 +2413,6 @@ xenFormatConfigCommon(virConfPtr conf,
>>   }
>>   
>>   
>> -/* Computing the vcpu_avail bitmask works because MAX_VIRT_CPUS is
>> -   either 32, or 64 on a platform where long is big enough.  */
>> -verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT);
> Umm, why are you declaring this to be dead code?

Good question.  Obviously my brain wasn't working.  I'll drop this patch.

Regards,
Jim




More information about the libvir-list mailing list