[libvirt] [PATCH v3 libvirt 3/3] qemu: add support for MTP filesystem

[Michal Privoznik]

On 20.08.2014 14:41, Eric Blake wrote:
> On 08/20/2014 06:19 AM, Giuseppe Scrivano wrote:
>> Michal Privoznik <mprivozn at redhat.com> writes:
>>
>>> Question that pops up immediately: do we want to commit to something
>>> that even qemu developers don't believe yet? What will happen when
>>> qemu decides to switch to 'root' attribute again? Libvirt will have to
>>> adapt which won't work with older qemus supporting 'x-root' only.
>>
>> I am not sure how usually libvirt deals with these cases, but to me it
>> seems like that we should use the "stable" attribute name; or just
>> postpone this series/feature.
>>
>>>
>>> And what's this desc= attribute for anyway? I've put in several
>>> different values and it seems to me like nothing changed.
>>
>> it is the name given to the MTP share on the guest, I see it displayed
>> in the guest, at least Nautilus shows it.
>
> Is the use of 'root'/'x-root' mandatory?  Is it something where we can
> commit to only a stable subset of the interface, with no way to name the
> root, and extend it later?
>

In fact, it's the most interesting attribute as it denotes the path that 
is to be shared via MTP. Without it, the whole MTP device is useless.

Having said that, I vote for postponing this patch until the dust on 
qemu side settles down.

Michal