[libvirt] [PATCH 01/13] vbox: Rewrite vboxNetworkOpen
Eric Blake
eblake at redhat.com
Wed Aug 20 18:27:24 UTC 2014
On 08/20/2014 10:20 AM, Michal Privoznik wrote:
> On 20.08.2014 02:17, Taowei wrote:
>> ---
>> src/vbox/vbox_common.c | 28 ++++++++++++++++++++++++++++
>> src/vbox/vbox_tmpl.c | 24 ------------------------
>> src/vbox/vbox_uniformed_api.h | 3 +++
>> 3 files changed, 31 insertions(+), 24 deletions(-)
>> + if ((data->pFuncs == NULL) ||
>> + (data->vboxObj == NULL) ||
>> + (data->vboxSession == NULL))
>> + goto cleanup;
>
> While you're at this you can reformat these, s/ +==/ ==/.
> Here and in the rest of the patches.
Or even shorter (dropping redundant (), and using ! instead of
comparison against NULL):
if (!data->pFuncs || !data->vboxObj || !data->vboxSession)
goto cleanup;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140820/14846314/attachment-0001.sig>
More information about the libvir-list
mailing list