[libvirt] [PATCH] qemu: call endjob in RevertToSnapshot

[Jincheng Miao]

On 08/27/2014 11:02 AM, Eric Blake wrote:
> On 08/26/2014 08:10 PM, Jincheng Miao wrote:
>> In qemuDomainRevertToSnapshot(), it will check snap->def->state.
>> But when the state is PMSUSPENDED/NOSTATE/BLOCKED, it forgets to
>> call qemuDomainObjEndJob.
>>
>> Signed-off-by: Jincheng Miao <jmiao at redhat.com>
>> ---
>>   src/qemu/qemu_driver.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
> This looks like the fix for
> https://bugzilla.redhat.com/show_bug.cgi?id=1134154 - thanks for chasing
> that!

This patch fix the part of that bug, but it doesn't touch the race 
condition:
Why the snap->def->state is NOSTATE? It should be RUNNING.
The only reasonable explanation is that snapshot object is free()ed.

IMHO, the SnapshotObjList should be clocked during snapshot job running.

>
> ACK, and I'll push soon.
>