[libvirt] [PATCH 04/10] storage_driver: Resolve Coverity REVERSE_INULL

Peter Krempa pkrempa at redhat.com
Wed Aug 27 14:50:56 UTC 2014


On 08/27/14 15:51, John Ferlan wrote:
> There were two occurrances of attempting to initialize actualType by
> calling virStorageSourceGetActualType(src) prior to a check if (!src)
> resulting in Coverity complaining about the possible NULL dereference
> in virStorageSourceGetActualType() of src.
> 
> Resolve by moving the actualType setting until after checking !src
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/storage/storage_driver.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

ACK, safe for 1.2.8

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140827/5d0d6873/attachment-0001.sig>


More information about the libvir-list mailing list