[libvirt] [PATCH 10/19] virsh-network: Resolve Coverity RESOURCE_LEAK

John Ferlan jferlan at redhat.com
Wed Aug 27 20:54:41 UTC 2014


Need to free 'xmlFromFile' on/for the error path when current was
returning false only

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 tools/virsh-network.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 578abe0..9497472 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -974,7 +974,7 @@ cmdNetworkUpdate(vshControl *ctl, const vshCmd *cmd)
     if (current) {
         if (live || config) {
             vshError(ctl, "%s", _("--current must be specified exclusively"));
-            return false;
+            goto cleanup;
         }
         flags |= VIR_NETWORK_UPDATE_AFFECT_CURRENT;
     } else {
-- 
1.9.3




More information about the libvir-list mailing list