[libvirt] [PATCH 13/19] phyp_driver: Resolve Coverity RESOURCE_LEAK

John Ferlan jferlan at redhat.com
Wed Aug 27 20:54:44 UTC 2014


Coverity determines that when jumping to the connected: label, the
addressinfo (ai) is not free'd.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/phyp/phyp_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index aa1e105..ea1981a 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -946,6 +946,7 @@ openSSHSession(virConnectPtr conn, virConnectAuthPtr auth,
         sock = socket(cur->ai_family, cur->ai_socktype, cur->ai_protocol);
         if (sock >= 0) {
             if (connect(sock, cur->ai_addr, cur->ai_addrlen) == 0) {
+                freeaddrinfo(ai);
                 goto connected;
             }
             VIR_FORCE_CLOSE(sock);
-- 
1.9.3




More information about the libvir-list mailing list