[libvirt] [PATCH 09/10] libxl_migration: Resolve Coverity NULL_RETURNS
John Ferlan
jferlan at redhat.com
Wed Aug 27 21:32:31 UTC 2014
<...snip...>
>>
>> Hmmm.. right
>>
>> Maybe a:
>>
>> if (event) {
>> libxlDomainEventQueue(driver, event);
>> event = NULL;
>> }
>>
>> before the:
>>
>> dom = virGetDomain(dconn, vm->def->name, vm->def->uuid);
>>
>
> Hrm, I wonder if it is even possible for dom to be NULL in this case?
> We are in the finish phase and have even unpaused the domain, if
> requested. I see that dom == NULL is never checked in
> qemuMigrationFinish(). Perhaps the whole 'if (dom == NULL)' check can
> be removed here too.
>
> Regards,
> Jim
>
OK - prior to reading this I just included this as patch 1 of the other
Coverity pile I just dumped on the list.
If you have an epiphany after reading the code again - let me know - I
can adjust it...
John
More information about the libvir-list
mailing list