[libvirt] [PATCH v2 0/4] Introduce support for virtio-blk-pci iothreads
John Ferlan
jferlan at redhat.com
Thu Aug 28 21:21:15 UTC 2014
On 08/27/2014 05:35 PM, John Ferlan wrote:
>
>
> On 08/26/2014 06:15 PM, John Ferlan wrote:
>> v1:
>> http://www.redhat.com/archives/libvir-list/2014-August/msg01155.html
>>
>> Changes since v1
>>
>> Patches 1-3 - purely from code review
>> Patch 4 - rework the checking of the to be added disk that has the iothread
>> property set to be done during qemuBuildDriveDevStr() after the config
>> check. This way the same checks are done for both start and hotplug.
>>
>> Only set the "inuse" bit after qemuBuildDriveDevStr() returns successfully
>> for both start and hotplug. This also enforces only setting for this path
>>
>> Since the only way a disk with the property can be added is if the current
>> emulator supports the feature, the calls to set/clear the bit if iothread
>> is set should be safe from not needing to also ensure iothreadmap exists.
>>
>> John Ferlan (4):
>> domain_conf: Introduce iothreads XML
>> qemu: Add support for iothreads
>> domain_conf: Add support for iothreads in disk definition
>> qemu: Allow use of iothreads for disk definitions
>>
>> docs/formatdomain.html.in | 34 ++++++++++++
>> docs/schemas/domaincommon.rng | 14 +++++
>> src/conf/domain_conf.c | 47 +++++++++++++++-
>> src/conf/domain_conf.h | 4 ++
>> src/qemu/qemu_capabilities.c | 2 +
>> src/qemu/qemu_capabilities.h | 1 +
>> src/qemu/qemu_command.c | 64 ++++++++++++++++++++++
>> src/qemu/qemu_hotplug.c | 6 ++
>> .../qemuxml2argv-iothreads-disk.args | 17 ++++++
>> .../qemuxml2argv-iothreads-disk.xml | 40 ++++++++++++++
>> tests/qemuxml2argvdata/qemuxml2argv-iothreads.args | 8 +++
>> tests/qemuxml2argvdata/qemuxml2argv-iothreads.xml | 29 ++++++++++
>> tests/qemuxml2argvtest.c | 4 ++
>> tests/qemuxml2xmltest.c | 2 +
>> 14 files changed, 271 insertions(+), 1 deletion(-)
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-disk.args
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-disk.xml
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads.args
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads.xml
>>
>
> Given Stephan's comment about allowing more than 1 disk per IOThread - I
> have removed the iothreadmap (and other remnants including docs).
>
> If folks want to see the changes before pushing that's fine, but since I
> figure I'm just removing code/checks - it'd still be "OK" for push. I
> will "wait" for an answer knowing the sleep/work cycles of the various
> interested parties are not the same as mine :-)
>
>
I pushed the changes without the iothreadmap
John
More information about the libvir-list
mailing list