[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] [PATCH 0/4] Add more snapshot API



Hey,

On Sat, Aug 02, 2014 at 10:41:45AM +0200, mail baedert org wrote:
> From: Timm B├Ąder <mail baedert org>
> 
> The following 4 patches add some more snapshot API to libvirt-glib.
> 
> I wasn't sure where to put _revert_to really, the libvirt API sounds
> like it belongs into GVirDomain (i.e. gvir_domain_revert_to_snapshot),
> but virDomainRevertToSnapshot only takes a pointer to the snapshot.

Snapshot XML which you get from libvirt contains a "domain" node with
the full domain configuration at the time the snapshot was created, and
I think the current domain configuration will be reverted to the
configuration stored in the snapshot when we revert to it.
I think it's ok to have this under GVirDomainSnapshot. If we put that in
GVirDomain, we'd have to make sure the snapshot we are trying to revert
to corresponds to the domain we are acting on.

Christophe

Attachment: pgp1r39wfGopb.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]