[libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

Himanshu Sharma himanshu.sharma at nectechnologies.in
Wed Aug 6 09:44:20 UTC 2014


Thanks for your response. I just wanted to know is there any way to fix this issue. Please provide me with the command that will help me to create "Clone" of VM running on ESXi also if possible also share the way to create "Template" of the VM running on ESXi.
It would be easier if we could manager ESXi from "Virtual Machine Manager".

-----Original Message-----
From: libvir-list-bounces at redhat.com [mailto:libvir-list-bounces at redhat.com] On Behalf Of Christophe Fergeau
Sent: 06 August 2014 15:05
To: libvir-list at redhat.com
Subject: Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

Hey,

Thanks for the detailed explanation!

On Tue, Aug 05, 2014 at 03:52:17PM +0200, Timm Bäder wrote:
> Also in reply to the 0/4:
> It will modify the existing one, as long as you don't change the name.
> Like if you use get_config, then set_description on that config and 
> then _set_config again, no additional snapshot will be created.
> If you change only the snapshot's name and then use set_config on it, 
> it'll create a new snapshot that is equivalent to the snapshot you 
> wanted to modify except for the name (and to really "modify" the old 
> snapshot, you now have to delete the old one, which is one reason why 
> we show the description to the user instead of the name in gnome-boxes).
> I had a conversation with eblake on IRC about this and it seemed like 
> this is the wanted behavior (or at least it's a well-known limitation?).
> 
> So I guess the name is still correct, but maybe the docs should 
> mention that renaming won't work as expected?

Hmm at this point I'd error out if the name is different. If people complain about this, or if this is too limiting, then we can reconsider with clear use cases to decide how this should behave. How does that sound?

Christophe



DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------
The contents of this e-mail and any attachment(s) are confidential and
intended
for the named recipient(s) only. 
It shall not attach any liability on the originator or NEC or its
affiliates. Any views or opinions presented in 
this email are solely those of the author and may not necessarily reflect the
opinions of NEC or its affiliates. 
Any form of reproduction, dissemination, copying, disclosure, modification,
distribution and / or publication of 
this message without the prior written consent of the author of this e-mail is
strictly prohibited. If you have 
received this email in error please delete it and notify the sender
immediately. .
-----------------------------------------------------------------------------------------------------------------------




More information about the libvir-list mailing list