[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config



On 06.08, Christophe Fergeau wrote:
> Hey,
> 
> Thanks for the detailed explanation!
> 
> On Tue, Aug 05, 2014 at 03:52:17PM +0200, Timm Bäder wrote:
> > Also in reply to the 0/4:
> > It will modify the existing one, as long as you don't change the name.
> > Like if you use get_config, then set_description on that config and
> > then _set_config again, no additional snapshot will be created.
> > If you change only the snapshot's name and then use set_config on it,
> > it'll create a new snapshot that is equivalent to the snapshot you
> > wanted to modify except for the name (and to really "modify" the old
> > snapshot, you now have to delete the old one, which is one reason why
> > we show the description to the user instead of the name in gnome-boxes).
> > I had a conversation with eblake on IRC about this and it seemed like
> > this is the wanted behavior (or at least it's a well-known limitation?).
> > 
> > So I guess the name is still correct, but maybe the docs should mention
> > that renaming won't work as expected?
> 
> Hmm at this point I'd error out if the name is different. If people
> complain about this, or if this is too limiting, then we can reconsider
> with clear use cases to decide how this should behave. How does that
> sound?
> 
> Christophe

That sounds good to me, thanks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]