[libvirt] [RFC PATCH 2/5] conf: Parse and format ivshmem device XML

[Martin Kletzander]

On Tue, Aug 05, 2014 at 06:48:02PM +0200, Maxime Leroy wrote:
>This patch adds configuration support for the ivshmem device
>as described in the schema in the previous patch.
>
>Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>
>---
> src/conf/domain_conf.c   | 234 ++++++++++++++++++++++++++++++++++++++++++++++-
> src/conf/domain_conf.h   |  40 ++++++++
> src/libvirt_private.syms |   4 +
> 3 files changed, 277 insertions(+), 1 deletion(-)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index c25c74b..829f1bf 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -234,7 +234,8 @@ VIR_ENUM_IMPL(virDomainDevice, VIR_DOMAIN_DEVICE_LAST,
>               "chr",
>               "memballoon",
>               "nvram",
>-              "rng")
>+              "rng",
>+              "ivshmem")
>
> VIR_ENUM_IMPL(virDomainDeviceAddress, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_LAST,
>               "none",
>@@ -759,6 +760,15 @@ VIR_ENUM_DECL(virDomainBlockJob)
> VIR_ENUM_IMPL(virDomainBlockJob, VIR_DOMAIN_BLOCK_JOB_TYPE_LAST,
>               "", "", "copy", "", "active-commit")
>
>+VIR_ENUM_IMPL(virDomainIvshmemServer, VIR_DOMAIN_IVSHMEM_SERVER_LAST,
>+              "yes",
>+              "no");
>+

Since commit bb018ce6c85ee17711a0d8c122c6861bb189ce56 we have
virTristateBool enym type for this.

>+VIR_ENUM_IMPL(virDomainIvshmemRole, VIR_DOMAIN_IVSHMEM_ROLE_LAST,
>+              "default",
>+              "master",
>+              "peer");
>+

I know I said that already, but just to be sure, this is not needed as
it doesn't make sense in qemu :(

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140807/2ff184a6/attachment-0001.sig>