[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: use unique dev names in <disk> examples



On 08/07/2014 09:35 AM, Martin Kletzander wrote:
> On Thu, Aug 07, 2014 at 08:38:11AM -0600, Eric Blake wrote:
>> Jiri Moskovcak reported on IRC that the documentation on valid
>> <disk> was confusing because it didn't have unique dev='...'
>> entries.
>>
>> * docs/formatdomain.html.in: Use unique names.
>>

>> -      &lt;target dev='hda' bus='ide'/&gt;
>> +      &lt;target dev='sdb' bus='ide'/&gt;
> 
> This one should start with "hd", it's IDE.  Or the bus should be
> changed.

Good catch.

> Rest looks fine, ACK if you match the dev/bus in those three mentioned
> places.

Fixed, and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]