[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 0/3] Add iSCSI hostdev pass-through device




On 08/05/2014 04:09 PM, John Ferlan wrote:
> Patches 1 & 2 are related to:
> 
> Update to http://www.redhat.com/archives/libvir-list/2014-July/msg01098.html
> 
> Patch 1/3 is already ACK'd, but felt it was easier to push together.
> 
> Patch 2/3 change since last:
>   - Fix typos as called in review of 8/8
>   - Adjust the rng file to 
>   - Change the order of things to be <source>, then <auth> to
>     follow how <disk> (and storage pools) do things.  That resulted
>     in code motion in domain_conf.c and adjustment to the *-iscsi-auth.xml
>     files 
> 
> Patch 3 is related to
> http://www.redhat.com/archives/libvir-list/2014-July/msg01268.html
> 
> 
> John Ferlan (3):
>   domain_conf: Common routine to handle network storage host xml def
>   hostdev: Add iSCSI hostdev XML
>   qemu: Remove extraneous space in function prototypes
> 
>  docs/formatdomain.html.in                          | 144 ++++++----
>  docs/schemas/domaincommon.rng                      |  48 +++-
>  src/conf/domain_conf.c                             | 289 +++++++++++++++------
>  src/qemu/qemu_capabilities.h                       |   2 +-
>  src/qemu/qemu_command.h                            | 136 +++++-----
>  src/qemu/qemu_conf.h                               |   2 +-
>  .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args  |  14 +
>  .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml   |  46 ++++
>  .../qemuxml2argv-hostdev-scsi-lsi-iscsi.args       |  14 +
>  .../qemuxml2argv-hostdev-scsi-lsi-iscsi.xml        |  40 +++
>  ...emuxml2argv-hostdev-scsi-virtio-iscsi-auth.args |  16 ++
>  ...qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml |  46 ++++
>  .../qemuxml2argv-hostdev-scsi-virtio-iscsi.args    |  16 ++
>  .../qemuxml2argv-hostdev-scsi-virtio-iscsi.xml     |  40 +++
>  tests/qemuxml2argvtest.c                           |  16 ++
>  tests/qemuxml2xmltest.c                            |   5 +
>  16 files changed, 672 insertions(+), 202 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi.xml
> 

Thanks for the review - these are now pushed with the adjustment to the
the 2/3 commit message to indicate that protocol='adapter' is possible
on read, but just not written out or documented.

Tks,

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]