[libvirt] [PATCHv3] conf: Add USB sound card support and implement it for qemu
Peter Krempa
pkrempa at redhat.com
Fri Aug 8 12:37:00 UTC 2014
On 08/08/14 10:23, Ján Tomko wrote:
> On 08/04/2014 11:46 AM, Peter Krempa wrote:
>> ---
>>
>> Notes:
>> Version 3:
>> - rebased after recent additions
>> Version 2:
>> - added docs
>>
>> docs/formatdomain.html.in | 5 +++--
>> src/conf/domain_conf.c | 3 ++-
>> src/conf/domain_conf.h | 1 +
>> src/qemu/qemu_capabilities.c | 2 ++
>> src/qemu/qemu_capabilities.h | 1 +
>> src/qemu/qemu_command.c | 14 ++++++++++++--
>> tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 +
>> tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 +
>> tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 +
>> tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 +
>> tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 +
>> tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 +
>> tests/qemuhelptest.c | 9 ++++++---
>> 13 files changed, 33 insertions(+), 8 deletions(-)
>>
>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index e5b1adb..409a76e 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -4981,9 +4981,10 @@ qemu-kvm -net nic,model=? /dev/null
>> The <code>sound</code> element has one mandatory attribute,
>> <code>model</code>, which specifies what real sound device is emulated.
>> Valid values are specific to the underlying hypervisor, though typical
>> - choices are 'es1370', 'sb16', 'ac97', and 'ich6'
>> + choices are 'es1370', 'sb16', 'ac97', 'ich6' and 'usb'.
>> (<span class="since">
>> - 'ac97' only since 0.6.0, 'ich6' only since 0.8.8</span>)
>> + 'ac97' only since 0.6.0, 'ich6' only since 0.8.8,
>> + 'usb' only since 1.2.7</span>)
>
> 1.2.8
>
> ACK with a xml->argv test added.
>
I've added the model to one of the existing sound card model tests and
pushed the patch.
Thanks for the review.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140808/588610b4/attachment-0001.sig>
More information about the libvir-list
mailing list