[libvirt] [PATCH] Include param.h in case of HAVE_BSD_CPU_AFFINITY

Michal Privoznik mprivozn at redhat.com
Mon Aug 11 09:14:19 UTC 2014


On 10.08.2014 11:44, Guido Günther wrote:
> This fixes compilation on kFreeBSD which otherwise fails like
>
>    CC       util/libvirt_util_la-virprocess.lo
> In file included from /usr/include/sys/cpuset.h:35:0,
>                   from util/virprocess.c:43:
> /usr/include/sys/_cpuset.h:49:43: error: 'NBBY' undeclared here (not in
> a function)
>    long __bits[howmany(CPU_SETSIZE, _NCPUBITS)];
>                                             ^
> In file included from util/virprocess.c:43:0:
> /usr/include/sys/cpuset.h:215:12: error: unknown type name 'cpusetid_t'
>   int cpuset(cpusetid_t *);
>              ^
> /usr/include/sys/cpuset.h:216:30: error: expected ')' before 'id_t'
>   int cpuset_setid(cpuwhich_t, id_t, cpusetid_t);
>                                ^
> /usr/include/sys/cpuset.h:217:42: error: expected ')' before 'id_t'
>   int cpuset_getid(cpulevel_t, cpuwhich_t, id_t, cpusetid_t *);
>                                            ^
> /usr/include/sys/cpuset.h:218:48: error: expected ')' before 'id_t'
>   int cpuset_getaffinity(cpulevel_t, cpuwhich_t, id_t, size_t, cpuset_t
> *);
>                                                  ^
> /usr/include/sys/cpuset.h:219:48: error: expected ')' before 'id_t'
>   int cpuset_setaffinity(cpulevel_t, cpuwhich_t, id_t, size_t, const
> cpuset_t *);
>
> And it's the correct usage as documented in
>
>    http://www.freebsd.org/cgi/man.cgi?query=cpuset_setid
> ---
>   src/util/virprocess.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/util/virprocess.c b/src/util/virprocess.c
> index 9179d73..4d6c50d 100644
> --- a/src/util/virprocess.c
> +++ b/src/util/virprocess.c
> @@ -40,6 +40,7 @@
>   #endif
>
>   #ifdef HAVE_BSD_CPU_AFFINITY
> +# include <sys/param.h>
>   # include <sys/cpuset.h>
>   #endif
>
>

ACK

Michal




More information about the libvir-list mailing list