[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] network: populate interface pool immediately when network is started



On 08/11/2014 12:59 PM, Laine Stump wrote:
> When a network is defined with "<pf dev='xyz'/>", libvirt will query
> sysfs to learn the list of all virtual functions (VF) associated with
> that Physical Function (PF) then populate the network's interface pool
> accordingly. This action was previously done only when the first guest
> actually requested an interface from the network. This patch changes
> it to populate the pool immediately when the network is started. This
> way any problems with the PF or its VFs will become apparent sooner.
> 
> Note that we can't remove the old calls to networkCreateInterfacePool
> that happen whenever a guest requests an interface - doing so would be
> asking for failures on hosts that had libvirt upgraded with a network
> that had been started but not yet used.
> 
> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1047818
> ---
>  src/network/bridge_driver.c | 212 ++++++++++++++++++++++----------------------
>  1 file changed, 107 insertions(+), 105 deletions(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]